Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1325 invalid way of calling first element of pdseries #1433

Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 24, 2025

Description

This uses iloc over empty bracket slicing

Related Issue

  • Closes #
  • Related to #

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1433.org.readthedocs.build/en/1433/

@wd60622 wd60622 linked an issue Jan 24, 2025 that may be closed by this pull request
@wd60622 wd60622 requested a review from juanitorduz January 24, 2025 16:40
@github-actions github-actions bot added MMM tests TVPs Related to time varying parameters bug Something isn't working good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (d9f0c51) to head (78bcfb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   94.62%   94.55%   -0.08%     
==========================================
  Files          50       50              
  Lines        5416     5416              
==========================================
- Hits         5125     5121       -4     
- Misses        291      295       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz merged commit 9994ee9 into main Jan 24, 2025
21 checks passed
@juanitorduz juanitorduz deleted the 1325-invalid-way-of-calling-first-element-of-pdseries branch January 24, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package MMM tests TVPs Related to time varying parameters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid way of calling first element of pd.Series
2 participants