Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Beta Geometric model #1301
Modified Beta Geometric model #1301
Changes from 4 commits
d480c2b
efa1d04
645f1fa
6d3301c
59e7722
3cc020c
a993465
7e1f364
8b47ff3
632ae67
291f28d
7101f80
a15a8d7
2476268
c868668
1ca5a9a
3a30fc3
1b13a12
56e8ac0
208e4f9
473616f
7a065c6
2303f82
5a7ae75
d494fff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 67 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L67
Check warning on line 70 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L70
Check warning on line 75 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L74-L75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this method just to deprecate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is to be deleted, then we should as well delete the associated
BetaGeoModel.expected_num_purchases
.Notice that we are inheriting, and a user may by mistake call the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to do this in a separate PR prior to merging this one. I don't think it should be added to the release notes because it's not deprecation in the truest sense of the term, but rather renaming a method.
Check warning on line 135 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L135
Check warning on line 143 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L141-L143
Check warning on line 147 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L145-L147
Check warning on line 150 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L150
Check warning on line 152 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L152
Check warning on line 157 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L154-L157
Check warning on line 159 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L159
Check warning on line 161 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L161
Check warning on line 199 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L198-L199
Check warning on line 202 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L201-L202
Check warning on line 204 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L204
Check warning on line 214 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L207-L214
Check warning on line 220 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L216-L220
Check warning on line 222 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L222
Check warning on line 252 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L251-L252
Check warning on line 255 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L254-L255
Check warning on line 262 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L257-L262
Check warning on line 266 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L264-L266
Check warning on line 268 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L268
Check warning on line 300 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L299-L300
Check warning on line 302 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L302
Check warning on line 312 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L306-L312
Check warning on line 314 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L314
Check warning on line 316 in pymc_marketing/clv/models/modified_beta_geo.py
Codecov / codecov/patch
pymc_marketing/clv/models/modified_beta_geo.py#L316