DiD: allow multiple pre/post intervention observations + correctness fixes #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
test_did_banks_simple
andtest_did_banks_multi
treated
predictor. This was equivalent to thegroup:post_treatment
interaction multiplication. But we've done away with this and have replacedtreated
withpost_treatment
which is is1
in all post treatment time points. This allows the model formula to mirror the DiD equations more closely, and makes things more explicit.There are clearly more ways in which DiD and the examples can be improved, but I think this PR represents a very good step forward that's worth merging at this point.