-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more conservative fastmath flags in numba backend #1147
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 82.14% 82.15% +0.01%
==========================================
Files 186 186
Lines 48207 48193 -14
Branches 8677 8677
==========================================
- Hits 39598 39593 -5
+ Misses 6441 6430 -11
- Partials 2168 2170 +2
|
Maybe we should only use these (or some other subset) by default?
All fastmath flags is really aggressive, and leads to some undefined behavior like in the nan case... |
2ea42ab
to
5acce78
Compare
@aseyboldt I moved the fastmath subflag definition to the |
5acce78
to
e2b4c65
Compare
e2b4c65
to
d480f5d
Compare
d480f5d
to
769d134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
Closes #1145
📚 Documentation preview 📚: https://pytensor--1147.org.readthedocs.build/en/1147/