Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support consecutive integer vector indexing in Numba backend #1106

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 27, 2024

Related to #818 and #772


📚 Documentation preview 📚: https://pytensor--1106.org.readthedocs.build/en/1106/

@ricardoV94 ricardoV94 force-pushed the numba_adv_subtensor branch 3 times, most recently from 37ef829 to 29ebb4b Compare November 27, 2024 12:34
@ricardoV94 ricardoV94 changed the title Support consecutive vector indices in Numba backend Support consecutive vector integer indices in Numba backend Nov 27, 2024
@ricardoV94 ricardoV94 changed the title Support consecutive vector integer indices in Numba backend Support consecutive integer vector indexing in Numba backend Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (ae66e82) to head (b050f31).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/numba/dispatch/subtensor.py 97.01% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.02%     
==========================================
  Files         183      183              
  Lines       48016    48085      +69     
  Branches     8648     8663      +15     
==========================================
+ Hits        39433    39500      +67     
- Misses       6417     6418       +1     
- Partials     2166     2167       +1     
Files with missing lines Coverage Δ
pytensor/tensor/subtensor.py 89.54% <100.00%> (+0.03%) ⬆️
pytensor/link/numba/dispatch/subtensor.py 95.34% <97.01%> (+0.95%) ⬆️

Copy link

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh that is sweet, thanks @ricardoV94 !

@ricardoV94 ricardoV94 merged commit bd281be into pymc-devs:main Nov 28, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants