Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support on_unused_input for string parameter names in eval #1085

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

tvwenger
Copy link
Contributor

@tvwenger tvwenger commented Nov 12, 2024

Description

Implements the feature requested in #1084

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1085.org.readthedocs.build/en/1085/

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (d9d8dba) to head (e425531).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         183      183           
  Lines       47932    47934    +2     
  Branches     8634     8635    +1     
=======================================
+ Hits        39355    39357    +2     
  Misses       6410     6410           
  Partials     2167     2167           
Files with missing lines Coverage Δ
pytensor/graph/basic.py 88.69% <100.00%> (+0.03%) ⬆️

pytensor/graph/basic.py Outdated Show resolved Hide resolved
@tvwenger
Copy link
Contributor Author

Thanks for supplying a better workaround for my use case in #1084 I'll leave this PR open though because this would still be a useful feature! I've implemented the change you requested.

@ricardoV94 ricardoV94 changed the title support on_unused_input="warn" for string parameter names in eval support on_unused_input for string parameter names in eval Nov 12, 2024
@ricardoV94
Copy link
Member

Thanks @tvwenger, changes look good

@ricardoV94 ricardoV94 merged commit 2315e69 into pymc-devs:main Nov 12, 2024
62 checks passed
@ricardoV94 ricardoV94 changed the title support on_unused_input for string parameter names in eval Support on_unused_input for string parameter names in eval Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Allow on_unused_input="ignore" for string keys in eval
2 participants