Subtract 1 from LU pivot indices

pymc-devs · Dec 31, 2024 · fe97e5d · fe97e5d
1 parent bc1f7d3
commit fe97e5d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/tests/link/numba/test_slinalg.py b/tests/link/numba/test_slinalg.py
@@ -252,7 +252,10 @@ def getrf(x):
 
     assert info == 0
     assert_allclose(LU, lu)
-    assert_allclose(IPIV, ipiv)
+
+    # TODO: It seems IPIV is 1-indexed in FORTRAN, so we need to subtract 1. I can't find evidence that scipy is doing
+    #  this, though.
+    assert_allclose(IPIV - 1, ipiv)
 
 
 @pytest.mark.parametrize("trans", [0, 1])