Skip to content

Commit

Permalink
Moved mypy from pre-commit to GitHub Action (#775)
Browse files Browse the repository at this point in the history
  • Loading branch information
HangenYuu authored May 21, 2024
1 parent 880a57a commit 863efc0
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 14 deletions.
44 changes: 44 additions & 0 deletions .github/workflows/mypy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: mypy

on:
pull_request:
push:
branches: [main]

jobs:
mypy:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
steps:
- uses: actions/checkout@v4
- name: Cache conda
uses: actions/cache@v4
env:
# Increase this value to reset cache if environment.yml has not changed
CACHE_NUMBER: 0
with:
path: ~/conda_pkgs_dir
key: ${{ runner.os }}-py310-conda-${{ env.CACHE_NUMBER }}-${{
hashFiles('environment.yml') }}
- uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-version: latest
mamba-version: "*"
activate-environment: pytensor-test
channel-priority: strict
environment-file: environment.yml
python-version: "3.10"
use-mamba: true
use-only-tar-bz2: false # IMPORTANT: This may break caching of conda packages! See https://github.com/conda-incubator/setup-miniconda/issues/267
- name: Install-pytensor and mypy dependencies
run: |
conda activate pytensor-test
pip install -e .
python --version
- name: Run mypy
run: |
conda activate pytensor-test
python ./scripts/run_mypy.py --verbose
14 changes: 0 additions & 14 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,3 @@ repos:
- id: ruff
args: ["--fix", "--output-format=full"]
- id: ruff-format
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.10.0
hooks:
- id: mypy
language: python
entry: python ./scripts/run_mypy.py --verbose
additional_dependencies:
- numpy>=1.20
- pandas
- types-filelock
- types-setuptools>=67.6.0.8
always_run: true
require_serial: true
pass_filenames: false
4 changes: 4 additions & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ dependencies:
# For testing
- coveralls
- diff-cover
- mypy
- types-filelock
- types-setuptools
- pytest
- pytest-cov
- pytest-xdist
Expand All @@ -41,6 +44,7 @@ dependencies:
# code style
- ruff
# developer tools
- pandas # required to run mypy script
- pre-commit
- packaging
- typing_extensions
Expand Down

0 comments on commit 863efc0

Please sign in to comment.