-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find_MAP
with close JAX integration and fix bug with Laplace fit
#385
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6aa20f7
Add JAX-based `find_MAP`
jessegrabowski 7ed3b2f
add `better_optimize` to CI envs
jessegrabowski e412f6f
Fix relative import
jessegrabowski f9b6258
Remove `find_MAP` import from module-level `__init__.py`
jessegrabowski ad3abd9
Update docstring
jessegrabowski be1d790
Allow calling `find_MAP` inside model context without model argument
jessegrabowski 923eb26
Required patched better_optimize
jessegrabowski f705d43
in-progress refactor
jessegrabowski a23762b
More refactor
jessegrabowski 2d21403
Generalize code to use any pytensor backend
jessegrabowski 4c2529d
Reconcile the two laplace approximation functions
jessegrabowski 07ebe40
Use absolute import in doctest
jessegrabowski b40e101
Fix imports
jessegrabowski bc340c2
Fix unrelated statespace test
jessegrabowski da338bf
- Rename argument `use_jax_gradients` -> `gradient_backend`
jessegrabowski 3ebbf20
Fix typo introduced by rename refactor
jessegrabowski 2035202
use `mode=FAST_COMPILE` to get `unobserved_value_vars` after MAP opti…
jessegrabowski f2504e9
Rename `test_jax_find_map.py` -> `test_find_map.py`
jessegrabowski a81079b
Improve docstring for `fit_laplace`
jessegrabowski 4d88343
Update tests to match new signature
jessegrabowski 9b1cd0e
Update docstring
jessegrabowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reconcile the two laplace approximation functions
- Loading branch information
commit 4c2529d67290dd00be54cb104dffcc4b1ca084a2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going through all the methods thinking when you would need
hess
andhessp
and then came back to this. I would probably warn the user / not let them pass bothuse_hess
anduse_hessp