Skip to content

Commit

Permalink
Remove dead code from kalman_filter.py (#393)
Browse files Browse the repository at this point in the history
* Remove `SteadyStateFilder`

Rename `CholeskyFilter` to `SquareRootFilter` to match the literature

* Use square root filter equations in `SquareRootFilter`

* Remove `SingleTimeSeriesFilter`

* Remove tests referencing old code
  • Loading branch information
jessegrabowski authored Nov 27, 2024
1 parent 4deeec6 commit 12e21de
Show file tree
Hide file tree
Showing 7 changed files with 163 additions and 315 deletions.
8 changes: 2 additions & 6 deletions pymc_experimental/statespace/core/statespace.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@

from pymc_experimental.statespace.core.representation import PytensorRepresentation
from pymc_experimental.statespace.filters import (
CholeskyFilter,
KalmanSmoother,
SingleTimeseriesFilter,
SquareRootFilter,
StandardFilter,
SteadyStateFilter,
UnivariateFilter,
)
from pymc_experimental.statespace.filters.distributions import (
Expand Down Expand Up @@ -53,9 +51,7 @@
FILTER_FACTORY = {
"standard": StandardFilter,
"univariate": UnivariateFilter,
"steady_state": SteadyStateFilter,
"single": SingleTimeseriesFilter,
"cholesky": CholeskyFilter,
"cholesky": SquareRootFilter,
}


Expand Down
8 changes: 2 additions & 6 deletions pymc_experimental/statespace/filters/__init__.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
from pymc_experimental.statespace.filters.distributions import LinearGaussianStateSpace
from pymc_experimental.statespace.filters.kalman_filter import (
CholeskyFilter,
SingleTimeseriesFilter,
SquareRootFilter,
StandardFilter,
SteadyStateFilter,
UnivariateFilter,
)
from pymc_experimental.statespace.filters.kalman_smoother import KalmanSmoother

__all__ = [
"StandardFilter",
"UnivariateFilter",
"SteadyStateFilter",
"KalmanSmoother",
"SingleTimeseriesFilter",
"CholeskyFilter",
"SquareRootFilter",
"LinearGaussianStateSpace",
]
Loading

0 comments on commit 12e21de

Please sign in to comment.