Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move BART case studies into seperate category #597

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

daniel-saunders-phil
Copy link
Contributor

@daniel-saunders-phil daniel-saunders-phil commented Nov 17, 2023

The case studies section of the examples should be subdivided into more specific categories. BART is a distinct type of modeling rather than a case study. We have enough notebooks for it now that it can stand on its own.

  • update thumbnail_extractor
  • standardize titles BART vs bart

📚 Documentation preview 📚: https://pymc-examples--597.org.readthedocs.build/en/597/

@juanitorduz
Copy link
Collaborator

@aloctavodia does this have any effect on BART docs (because of the paths?)

@OriolAbril
Copy link
Member

OriolAbril commented Nov 17, 2023

we can set up redirects to preserve the old paths, but bart docs should use the (target)= at the top of the notebook to reference them for things like that; if the target doesn't change, the cross-reference is still valid.

Links from discourse to notebooks and stuff like that can't use cross-references, so redirects are a good idea

@OriolAbril
Copy link
Member

add redirects here: https://github.com/pymc-devs/pymc-examples/blob/main/examples/conf.py#L155; keys are old/unexistent paths (redirect origin), values are existing paths (redirect endpoint)

@twiecki
Copy link
Member

twiecki commented Nov 17, 2023

@OriolAbril I don't think we need to add redirects, if people want stable links they should reference a specific version of the docs.

@aloctavodia
Copy link
Member

Thanks, @daniel-saunders-phil for the PR. I am working on BART right now I will update the paths if necessary.

@twiecki twiecki merged commit 0ce7ddb into pymc-devs:main Nov 17, 2023
1 check passed
alporter08 pushed a commit to alporter08/pymc-examples that referenced this pull request Nov 20, 2023
* move BART case studies into seperate category

* added BART category to sphinxext

* synchronized names between folder and thumnail_extractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants