Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky recursion test on PyPy #2661

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Skip flaky recursion test on PyPy #2661

merged 1 commit into from
Dec 21, 2024

Conversation

jacobtylerwalls
Copy link
Member

Follow-up to 03cd54c.

No one has the time or inclination to find a stable recursion limit that is low enough to reliably trigger the UserWarning without actually causing core dumps or other problems, esp. when running with coverage.

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining astroid or the dev workflow backport maintenance/3.3.x labels Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (b5bb771) to head (7e2d6fe).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2661   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          93       93           
  Lines       11083    11083           
=======================================
  Hits        10331    10331           
  Misses        752      752           
Flag Coverage Δ
linux 93.09% <ø> (ø)
pypy 93.21% <ø> (ø)
windows 93.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strongly agree with this decision

@jacobtylerwalls jacobtylerwalls merged commit 30ddb25 into main Dec 21, 2024
22 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/skip-flaky branch December 21, 2024 21:43
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2661-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 30ddb250a4c15aadf5d397fa42a96a2ac108c8d8
# Push it to GitHub
git push --set-upstream origin backport-2661-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2661-to-maintenance/3.3.x.

jacobtylerwalls added a commit that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants