-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid commented-out code (ruff-ERA) #545
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Pull Request Test Coverage Report for Build 12794832937Details
💛 - Coveralls |
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
And remove outdated comment. Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good to me. Where the commented code was intentional to highlight something, I just replaced it with an equivalent english statement. Otherwise I went in and resolved the remaining complains by a combination of deletion and uncommenting
Some of the pieces are commented well, however, since we cannot quarantee good comments I suggest avoiding commented-out code entirely to avoid confusion.