Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid commented-out code (ruff-ERA) #545

Merged
merged 6 commits into from
Jan 15, 2025
Merged

avoid commented-out code (ruff-ERA) #545

merged 6 commits into from
Jan 15, 2025

Conversation

XzzX
Copy link
Contributor

@XzzX XzzX commented Jan 15, 2025

Some of the pieces are commented well, however, since we cannot quarantee good comments I suggest avoiding commented-out code entirely to avoid confusion.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/ruff-era

@XzzX XzzX requested a review from liamhuber January 15, 2025 07:29
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (53a5c14) 3356 3070 91.48%
Head commit (c683038) 3356 (+0) 3070 (+0) 91.48% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#545) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12794832937

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.478%

Totals Coverage Status
Change from base Build 12773583061: 0.0%
Covered Lines: 3070
Relevant Lines: 3356

💛 - Coveralls

And remove outdated comment.

Signed-off-by: liamhuber <[email protected]>
Signed-off-by: liamhuber <[email protected]>
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good to me. Where the commented code was intentional to highlight something, I just replaced it with an equivalent english statement. Otherwise I went in and resolved the remaining complains by a combination of deletion and uncommenting

@liamhuber liamhuber merged commit 10bb5c5 into main Jan 15, 2025
18 checks passed
@liamhuber liamhuber deleted the ruff-era branch January 15, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants