Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Write a workflow that runs tests on the latest conda release #334

Merged
merged 2 commits into from
May 24, 2024

Conversation

liamhuber
Copy link
Member

No description provided.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/test_conda

Copy link

codacy-production bot commented May 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c5b71a) 3948 3526 89.31%
Head commit (a63ed94) 3948 (+0) 3526 (+0) 89.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#334) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9230154718

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.311%

Totals Coverage Status
Change from base Build 9115999265: 0.0%
Covered Lines: 3526
Relevant Lines: 3948

💛 - Coveralls

@liamhuber
Copy link
Member Author

It looks like the file didn't write or something?

Run python $GITHUB_ACTION_PATH/../.support/condamerge.py ./environment.yml > ./environment.yml
Traceback (most recent call last):
  File "/home/runner/work/_actions/pyiron/actions/make_pip_optional/write-environment/../.support/condamerge.py", line 80, in <module>
    merge_env(
  File "/home/runner/work/_actions/pyiron/actions/make_pip_optional/write-environment/../.support/condamerge.py", line 65, in merge_env
    env_base['channels'],
TypeError: 'NoneType' object is not subscriptable

and

Run mamba env update -n my-env -f ./environment.yml

SpecNotFound: '/home/runner/work/pyiron_workflow/pyiron_workflow/environment.yml' is empty

Not sure if this is because of bad formatting of the env file, a mistake in pwd, or the env updater trying to read and write to the same place.

@liamhuber
Copy link
Member Author

 ModuleNotFoundError: No module named 'test_macro'
E......Traceback (most recent call last):
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/backend/serial.py", line 65, in <module>
    main(argument_lst=sys.argv)
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/backend/serial.py", line 31, in main
    input_dict = interface_receive(socket=socket)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/miniconda3/envs/my-env/lib/python3.12/site-packages/pympipool/shared/communication.py", line 167, in interface_receive
    return cloudpickle.loads(socket.recv())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'test_node'

Ok, this is just the pympipool error because I didn't put the tests in the python path.

@liamhuber
Copy link
Member Author

 ======================================================================
ERROR: test_pull_and_executors (test_workflow.TestWorkflow.test_pull_and_executors)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pyiron_workflow/pyiron_workflow/tests/unit/test_workflow.py", line 416, in test_pull_and_executors
    self.assertEquals(
    ^^^^^^^^^^^^^^^^^
AttributeError: 'TestWorkflow' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

----------------------------------------------------------------------

Right, python 3.12 totally deprecated my spelling mistake. It's patched now, but that PR is not in the latest release I'm testing here. Simplest to downgrade python for this test for now. It's actually the test itself failing and not the source code, so I don't feel too terrible about this. Good reminder to pay attention to deprecation warnings though.

liamhuber added 2 commits May 24, 2024 14:29
Because it happens on opening, I need the new target to actually be merged to main to test it! Let's sneak that in here, even though it's unrelated
@liamhuber
Copy link
Member Author

Note: comment history on this page wont' make much sense anymore, because I force-pushed over all the development and debug commits.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c5b71a) 3948 3526 89.31%
Head commit (7bab379) 3948 (+0) 3526 (+0) 89.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#334) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@liamhuber liamhuber changed the title Write a workflow that runs tests on the latest conda release [patch] Write a workflow that runs tests on the latest conda release May 24, 2024
@liamhuber liamhuber merged commit e2a1d7f into main May 24, 2024
18 checks passed
@liamhuber liamhuber deleted the test_conda branch May 24, 2024 21:38
@liamhuber
Copy link
Member Author

Super. Test failed, but in exactly the expected way for the last release -- with the assertEquals deprecation in py3.12. 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants