Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URIRef for the workflow-specific KG node and define pyiron namespace #100

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

samwaseda
Copy link
Member

One thing that didn't make sense at all in this PR was that the user was asked to provide a namespace which was used for the workflow logic and the variable names. Now I propose to use simple URIRef for all workflow-specific knowledge graph nodes such as my_workflow.my_node.inputs.my_argument, and for all pyiron_workflow-specific objects we use a pyiron_workflow namespace, which for now I called http://pyiron.org/ontology, which should probably be changed later.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_ontology/uriref

Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bf4e204) 583 537 92.11%
Head commit (ed384bb) 578 (-5) 532 (-5) 92.04% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#100) 21 21 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@samwaseda samwaseda mentioned this pull request Jan 21, 2025
Base automatically changed from use_predefined_tags to parse_full_workflow January 22, 2025 06:25
@samwaseda samwaseda merged commit d69c39f into parse_full_workflow Jan 22, 2025
17 checks passed
@samwaseda samwaseda deleted the uriref branch January 22, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants