Pixelarray SDL3 #3309
Pixelarray SDL3 #3309
Conversation
| #define PXM_GET_PIXELVALS(_sR, _sG, _sB, _sA, px, fmt, palette, ppa) \ | ||
| PG_GetRGBA(px, fmt, palette, &(_sR), &(_sG), &(_sB), &(_sA)); \ | ||
| if (!ppa) { \ | ||
| _sA = 255; \ | ||
| } | ||
|
|
||
| #define PXM_GET_PIXELVALS_1(sr, sg, sb, sa, _src, _palette) \ | ||
| sr = _palette->colors[*((Uint8 *)(_src))].r; \ | ||
| sg = _palette->colors[*((Uint8 *)(_src))].g; \ | ||
| sb = _palette->colors[*((Uint8 *)(_src))].b; \ | ||
| sa = 255; | ||
|
|
There was a problem hiding this comment.
Once surface.h is ported over (where the non PXM_ variants of these macros live), these should be removed and everyone should use the one consistent set.
| @@ -828,13 +859,12 @@ _compare(pgPixelArrayObject *array, PyObject *args, PyObject *kwds) | |||
| return 0; | |||
| } | |||
|
|
|||
| new_format = surf->format; | |||
There was a problem hiding this comment.
This function goes from 3 pixel formats to 2. new_format == format as the code was written previously.
Should it actually be a format derived from new_surf instead of surf? Was the previous implementation a typo?
I'm not fully sure, but this translates it as was written.
Starbuck5
force-pushed
the
pixelarray-sdl3
branch
2 times, most recently
from
644a2ec to
4696146
Compare
Starbuck5
force-pushed
the
pixelarray-sdl3
branch
from
92f0a40 to
ec2bdd0
Compare
| @@ -1021,20 +1029,23 @@ _array_assign_array(pgPixelArrayObject *array, Py_ssize_t low, Py_ssize_t high, | |||
| } | |||
| break; | |||
| case 3: { | |||
| // Note: | |||
| // Why is the 24 bit case pixelformat aware but none of the rest are? | |||
| // - Starbuck, jan. 2025 | |||
There was a problem hiding this comment.
How are the rest of the paths not pixelformat aware? I think they are assuming that source and destination pixelformats are same and therefore directly copying over the data. But I didn't find this check enforced in the code anywhere on a quick search?
Today I ported a few modules and worked on a few others.
I first did everything with explicit SDL2 vs SDL3 code to observe patterns, then I made a few new compatibility macros to match what I saw.
This PR is those macros + the pixelarray module.