Move get_rect helper to c_api #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
approved these changes
Jan 24, 2025
Starbuck5
added
Code quality/robustness
|
Joystick segfaulting doesn't really seem to have anything to do with this PR so I think it's safe to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper used to create the return value of
Surface.get_(f)rectto public base api. So far that function was only used inside of Surface class, but since that same functionality is present inpygame._sdl2.Textureandpygame._sdl2.Imageclasses I moved it to public api to make it easier for implementation in the future (when we rewrite Texture/Image in C). That will also make it easier to implement extra stuff for those classes (like FRect support for both, or keyword support for Image.get_rect)