Introduce PG_SURF_FORMATENUM macro (SDL3 compat) #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Brings SDL3 just a bit closer. Rotozoom.c for example now compiles, previously did not. - Simplify 2 pixel format checks - Remove unneeded include from transform.c
Starbuck5
added
Code quality/robustness
ankith26
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro is the same as PG_SurfaceFormatEnum from gresm's surface PR #3215, but named as a macro and applied throughout the project. Except for window.c, because I didn't want to cause a merge conflict with Ankith's window SDL3 PR.