Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Meetup rsvp integration #12

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[WIP] Meetup rsvp integration #12

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2017

Haven't included suggesions from @aktech on @CuriousLearner 's PR.

Copy link
Contributor

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

As discussed, please use a separate branch for your meetup integration feature. You could take reference from PR #10 .

Let me know when you do this. Also, make sure to write tests for your code.


# For having multiple paginated calls to Explara till all the data is
# synced with the database
while True:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use separate branch and use reference from explara integration PR to get this done?

@CuriousLearner
Copy link
Contributor

@akash-47 Can you please do cherry-pick your commit and rebase the branch to match with current version of develop?

@CuriousLearner
Copy link
Contributor

@akash-47 Can you please update this?

Please let us know if you don't have time to work on this.

@CuriousLearner
Copy link
Contributor

@akash-47 Do you have time to take this forward?

@ghost
Copy link
Author

ghost commented Jun 8, 2017

Apologies for not replying earlier. I wont be able to work on this for the next two months.
Can someone else take this up?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant