-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CarpetBombing task #356
Support for CarpetBombing task #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got 3 unrelated PRs in this PR:
- Add CarpetBombing
- Fix an incorrect Auto value
- Delete a duplicate test
I could have merged 2/3 of those if they'd been distinct PRs. It makes things go a lot more smoothly when PRs are split up.
@DanAlbert - merge PR #357 first, I'll rebase this and then the tests here will pass. |
69d3199
to
d08cd2c
Compare
@DanAlbert - rebased, ready to be merged. |
def __eq__(self, other: Any) -> bool: | ||
if isinstance(other, str): | ||
return self.value == other | ||
if isinstance(other, Expend): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close enough so meh, non-blocking, but for the future just return super().__eq__(other)
after doing any custom checks.
# hardcoded parameters are present in .miz file, but not visible in Mission Editor | ||
self.params = { | ||
"altitude": alt_above, | ||
"altitudeEnabled": True if alt_above != CarpetBombing.DEFAULT_ALT else False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is actually right. I suspect this field is supposed to be "did the caller make a choice, or did they use the default?". This can't distinguish between a chosen altitude of 2000 and a default behavior. For that you need alt_above: int | None = None
.
I've also got no idea what the impact of getting this wrong is. Might be just UI behavior in the ME? I won't block on this for now, but for future reference, that's how this thing ought to be written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, fyi, this is just a more verbose way to write "altitudeEnabled": alt_above != CarpetBombing.DEFAULT_ALT
This change allows WWIIBigFormation to use Carpet Bombing task. Removed duplicate tests for big formation which crept in with PR pydcs#351
This change allows WWIIBigFormation to use Carpet Bombing task. Removed duplicate tests for big formation which crept in with PR pydcs#351
This change allows WWIIBigFormation to use Carpet Bombing task.
Removed duplicate tests for big formation which crept in with PR #351