feat(logging): Enhance logging in retry decorator #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the @Retry decorator to support sequential, logarithmic, and exponential backoff strategies. - Added optional jitter to backoff intervals to handle the thundering herd problem. - Updated the README.md to document these new features. Tests: - Added unit tests for the new backoff strategies and jitter functionality.
…ckoff tracking - Added logging configuration with basic setup using logging.basicConfig(level=logging.INFO). - Replaced print statements with logger.info to provide structured and detailed logs for each retry attempt. - Ensured exceptions and backoff intervals are logged for easier debugging and monitoring. - Maintained backward compatibility and ensured existing functionality remained intact. This enhancement facilitates improved tracking of retry attempts and backoff intervals, aiding in better debugging and system monitoring.
…details - Updated retry attempt logs to include backoff type and jitter status for clearer context. - Ensured exceptions and backoff intervals were logged for easier debugging and monitoring. - Maintained backward compatibility and ensured existing functionality remained intact.
rjvitorino
changed the title
rjvitorino
changed the title
- Adjusted backoff strategy calculation in the calculate_backoff function - Corrected exponential backoff calculation formula - Ensured code compliance with Black formatting standards
- Added missing newline after imports - Corrected logging statement formatting in retry decorator - Improved readability by adding blank lines in test functions - Fixed formatting for retry decorator parameters in test cases - Ensured consistent formatting for expressions involving power operator in tests
pydanny
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the logging within the retry decorator to provide more detailed insights into the retry behavior. The changes include logging the chosen backoff strategy, the backoff increment, whether jitter is enabled, and the number of retries. This additional logging information helps in tracking the backoff intervals and understanding the retry strategy more clearly, making debugging and monitoring easier.
Changes Made
Related Issues
This pull request closes issue #7 by adding the necessary logging to track backoff strategies and retry attempts.
Dependencies
This pull request should be merged after PR #38, which includes necessary refactoring and base improvements for the retry decorator.
Checklist
Testing