Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update PyConTW 2023 to 2024 #464

Merged
merged 15 commits into from
Jan 31, 2024
Merged

feat: update PyConTW 2023 to 2024 #464

merged 15 commits into from
Jan 31, 2024

Conversation

SivanYeh
Copy link
Collaborator

@SivanYeh SivanYeh commented Jan 22, 2024 •
edited
Loading

feat:

  • update PyConTW 2023 to 2024 including few names, links, containers and docker setting.
  • hide items that are unready yet.
  • update volunteer recruitment link

@SivanYeh
feat: update PyConTW 2023 to 2024
276de53 
feat:
- update PyConTW 2023 to 2024 including few names, links, containers and docker setting.
- hide items that are unready yet.
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024 •
edited
Loading

✅ Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit 5db4bd7
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/65b667ab4ff1000008220dce
😎 Deploy Preview https://deploy-preview-464--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh SivanYeh linked an issue Jan 22, 2024 that may be closed by this pull request
[Feature Request] Landing Page - 2024 Migration #461
Closed
@SivanYeh SivanYeh requested review from mattwang44 and removed request for mattwang44 January 22, 2024 09:35
@mattwang44
Copy link
Member

mattwang44 commented Jan 22, 2024 •
edited
Loading

過去習慣是當年度 code 確定不再更動後要打個 release tag（以免未來哪天需要回去修改舊網站會比較好找）再開始新年度的開發，但我好像沒看到 2023-final tag？
https://github.com/pycontw/pycontw-frontend/releases

mattwang44
mattwang44 reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@mattwang44 mattwang44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 首頁圖片與文字敘述都還是 2023，若新圖與新文案還沒出來的話看是否要先拿掉？
  • 首頁「查看議程」按鈕是否該改成別的連結？志工招募或者 CFP?
  • footer 志工召募連結還是 2023 的
  • 其他的 CFP 頁面與如何投稿頁面裡面也都還是 2023
image image image

@rockleona
fix: page import error (#465)
2edd88d 
* fix: import page error

* Fix Linter
@SivanYeh SivanYeh self-assigned this Jan 24, 2024
SivanYeh and others added 6 commits January 26, 2024 20:12
mattwang44
mattwang44 reviewed Jan 27, 2024
View reviewed changes
configs/pageSponsors.js Outdated Show resolved Hide resolved
mattwang44
mattwang44 reviewed Jan 27, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@SivanYeh SivanYeh merged commit a9f11a8 into main Jan 31, 2024
5 checks passed
@SivanYeh SivanYeh deleted the 2024-migrate-frontend branch January 31, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 left review comments

Assignees

@SivanYeh SivanYeh

Labels
None yet
Projects
PyConTW'24 Dev-Web Kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Landing Page - 2024 Migration
3 participants
@SivanYeh @mattwang44 @rockleona