Update/ccip layout for sponsor and discord page #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
josix
commented
Aug 26, 2023
josix
commented
Aug 26, 2023
|
LGTM! |
SivanYeh
approved these changes
Aug 27, 2023
SivanYeh
approved these changes
Aug 27, 2023
SivanYeh
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Apply ccip layout that hides header and footer when showing
discordpage andsponsorpageSteps to Test This Pull Request
/ext/discord?ccip=trueandabout/sponsorin rwd modeExpected behavior
Disable displaying header and footer when using ccip layout, and keep other elements as usual
Related Issue
#426 #446
Additional context