Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keynote): prevent replaceAll on null when speaker_name_en_us is empty #431

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix(keynote): prevent replaceAll on null when speaker_name_en_us is empty #431

merged 1 commit into from
Aug 4, 2023

Conversation

josix
Copy link
Collaborator

@josix josix commented Aug 4, 2023

Types of changes

  • Bugfix

Description

  • prevent replaceAll on null when speaker_name_en_us is empty

Steps to Test This Pull Request

  1. go to page http://localhost:3000/2023/zh-hant/conference/keynotes or http://localhost:3000/2023/en-us/conference/keynotes

Expected behavior

localhost_3000_2023_zh-hant_conference_keynotes

Related Issue

Additional context

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit b2f496f
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/64ccc5c688b55800080993b7
😎 Deploy Preview https://deploy-preview-431--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@josix josix merged commit 7b725c8 into main Aug 4, 2023
5 checks passed
@josix josix deleted the fix/2023-keynote branch August 4, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baby230211 baby230211 baby230211 approved these changes

@tim08094495757 tim08094495757 Awaiting requested review from tim08094495757

@SivanYeh SivanYeh Awaiting requested review from SivanYeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josix @baby230211