Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): reduce horizontal padding in header #430

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

josix
Copy link
Collaborator

@josix josix commented Aug 4, 2023

#429

Types of changes

  • Bugfix

Description

  • reduce horizontal padding in header

Steps to Test This Pull Request

  1. Go to index page

Expected behavior

image image

Related Issue

#429

Additional context

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit a724085
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/64cf9f0cdc6546000983c7e8
😎 Deploy Preview https://deploy-preview-430--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@josix josix requested a review from SivanYeh August 4, 2023 09:08
@josix josix linked an issue Aug 4, 2023 that may be closed by this pull request
@baby230211
Copy link
Collaborator

Actually we can just use one css to work on this issue.
add

flex-shrink: 0

on core-homeIcon

@josix josix force-pushed the fix/navbar branch 2 times, most recently from 63de977 to b86e819 Compare August 4, 2023 18:16
@josix
Copy link
Collaborator Author

josix commented Aug 4, 2023

Actually we can just use one css to work on this issue. add

flex-shrink: 0

on core-homeIcon

Thanks, I've added it to core-homeIcon. However, I leave the update of padding since @anan0202 decided to change the space between the nav items.
I'm wondering that if there is other better solution to make dynamic padding between nav items but fix the position of locale-switch and home icon. Do you have any suggestions?

Comment on lines 37 to +38
@apply text-pink-700;
flex-shrink: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to move to class

Comment on lines 49 to +50
@apply font-bold;
flex-shrink: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to move to class

Copy link
Contributor

@yungshenglu yungshenglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yungshenglu yungshenglu merged commit 1ccabbb into main Aug 17, 2023
5 checks passed
@yungshenglu yungshenglu deleted the fix/navbar branch August 17, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] The Nav Title - (pycontw 2023) is break line on en
3 participants