Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added raw api_get, api_put, api_post methods #1711

Closed
wants to merge 2 commits into from

Conversation

dja852
Copy link

@dja852 dja852 commented Aug 10, 2023

Added 3 new methods to the JIRA class (get, put, and post) to enable a user to send a raw API call leveraging the established JIRA session and return a Response object for further handling.

This is useful to interact with an API endpoint not yet supported by this package.

Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: feature

@adehad
Copy link
Contributor

adehad commented Dec 21, 2023

I'm hesitant to add this, we have the existing self._session which would give more flexibility to users who do want to create their own methods.

I think this example works best for the GET requests but for the others where there are other keyword arguments that could be added it is unfortunately limiting.

Perhaps we can add some documentation on how to add custom methods, eg via subclassing to highlight the recommended way to handle unsupported endpoints?

Thank you for the effort of this contribution, sorry it didn't work out this time, but look forward to more!

@adehad adehad closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants