Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure large write calls cannot overflow the buffer in ThreadedGzipWriter #164

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

rhpvorderman
Copy link
Collaborator

Checklist

  • Pull request details were added to CHANGELOG.rst
  • Documentation was updated (if needed)

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (71b7d61) 94.78% compared to head (dc7f6dd) 94.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
- Coverage    94.78%   94.67%   -0.11%     
===========================================
  Files            3        3              
  Lines          441      451      +10     
  Branches        72       74       +2     
===========================================
+ Hits           418      427       +9     
+ Misses          18       17       -1     
- Partials         5        7       +2     
Files Coverage Δ
src/isal/igzip_threaded.py 94.66% <100.00%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhpvorderman rhpvorderman merged commit 36551e5 into develop Oct 12, 2023
20 checks passed
@rhpvorderman rhpvorderman deleted the fixbuffercrash branch October 12, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant