feat: support redis version >= 5 in dependency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nekotoxin please review |
|
|
iashraful
force-pushed
the
redis-range-of-ver
branch
2 times, most recently
from
e188787 to
b19bf5e
Compare
hsluoyz
changed the title
|
@iashraful plz fix CI errors:
|
iashraful
force-pushed
the
redis-range-of-ver
branch
from
84c6345 to
accc5dd
Compare
|
@iashraful can you fork this project and test the CI in your own repo? In your own repo, the CI will be exactly the same. If everything passed, then update this PR. The reason is that as first-time contributor, every update in this PR would require a member to click a button to allow CI to re-run, which may be a stopper of the debugging process. |
iashraful
force-pushed
the
redis-range-of-ver
branch
from
accc5dd to
ad838e0
Compare
|
Closed for now, still looking forward to an improved and fully-tested PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested with Python 3.10 and 3.9 Along with redis 5.0.1. So, putting redis>=4.5.2 means it'll accept any newer version.