-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScienceDirect: SubjectClassifications API #356
base: master
Are you sure you want to change the base?
Conversation
But it does return different data, does it? |
Yes it returns different data (with the same structure). Here is an example: scopus_sc = SubjectClassifications({'description': 'Chemistry'}, refresh=True)
scdir_sc = ScDirSubjectClassifications({'description': 'Chemistry'}, refresh=True) Scopus
ScienceDirect Results
|
self._api = 'SubjectClassifications' if 'scopus' in self.__module__ else 'ScienceDirectSubjectClassifications' | ||
Search.__init__(self, query=query, api=self._api, **kwds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the api is passed as a parameter, it is not needed as underscore property. If it is needed elsewhere, it can stay underscore property but need not be passed as parameter.
So, is it used somewhere else? If not, let's just make pass a simple parameter.
the md5-hashed version of `query` dict turned into string in format | ||
of `'key=value'` delimited by `'&'`. | ||
""" | ||
SubjectClassifications.__init__(self, query=query, refresh=refresh, fields=fields, **kwds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add newline.
This API works exactly the same as the one of Scopus. To avoid code redundancy and increase maintainability this class simply inherits the one from Scopus