Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't strip with BUILD_TYPE None #5392

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jspricke
Copy link
Contributor

Description

Debian builds with None by default and takes care of stripping itself.
This allows building debug symbol packages.

Suggested changelog entry:

Don't strip with CMAKE_BUILD_TYPE None

Debian builds with None by default and takes care of stripping itself.
This allows building debug symbol packages.
@jspricke jspricke requested a review from henryiii as a code owner September 30, 2024 14:28
@henryiii henryiii merged commit 167bb5f into pybind:master Jan 24, 2025
78 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants