Adding py::smart_holder (for smart-pointer interoperability). by rwgk · Pull Request #2672 · pybind/pybind11

Adding test_unique_ptr_member (for desired PyCLIF behavior).

Ralf W. Grosse-Kunstleve

committed

unique_ptr or shared_ptr return

Ralf W. Grosse-Kunstleve

committed

new test_variant_unique_shared with vptr_holder prototype

Ralf W. Grosse-Kunstleve

committed

moving prototype code to pybind11/vptr_holder.h, adding type_caster specialization to make the bindings involving unique_ptr passing compile, but load and cast implementations are missing

Ralf W. Grosse-Kunstleve

committed

disabling GitHub Actions on pull_request (for this PR)

Ralf W. Grosse-Kunstleve

committed

disabling AppVeyor (for this PR)

Ralf W. Grosse-Kunstleve

committed

TRIGGER_SEGSEV macro, annotations for GET_STACK (vptr::get), GET_INT_STACK (pointee)

Ralf W. Grosse-Kunstleve

committed

adding test_promotion_of_disowned_to_shared

Ralf W. Grosse-Kunstleve

committed

Copying tests as-is from xxx_value_ptr_xxx_holder branch.

Ralf W. Grosse-Kunstleve

committed

Copying tests as-is from xxx_value_ptr_xxx_holder branch.

Ralf W. Grosse-Kunstleve

committed

Demonstration of Undefined Behavior in handling of shared_ptr holder.

Ralf W. Grosse-Kunstleve

committed

Additional demonstration of Undefined Behavior in handling of shared_ptr holder.

Ralf W. Grosse-Kunstleve

committed

fixing up-down mixup in comment

Ralf W. Grosse-Kunstleve

committed

Demonstration of Undefined Behavior in handling of polymorphic pointers.

Ralf W. Grosse-Kunstleve

committed

minor test_private_first_base.cpp simplification (after discovering that this can be wrapped with Boost.Python, using boost::noncopyable)

Ralf W. Grosse-Kunstleve

committed

pybind11 equivalent of Boost.Python test similar to reproducer under pybind#1333

Ralf W. Grosse-Kunstleve

committed

Snapshot of WIP, TODO: shared_ptr deleter with on/off switch

Ralf W. Grosse-Kunstleve

committed

Adding vptr_deleter.

Ralf W. Grosse-Kunstleve

committed

Adding from/as unique_ptr<T> and unique_ptr<T, D>.

Ralf W. Grosse-Kunstleve

committed

Adding from_shared_ptr. Some polishing.

Ralf W. Grosse-Kunstleve

committed

New tests/core/smart_holder_poc_test.cpp, using Catch2.

Ralf W. Grosse-Kunstleve

committed

Adding in vptr_deleter_guard_flag.

Ralf W. Grosse-Kunstleve

committed

Improved labeling of TEST_CASEs.

Ralf W. Grosse-Kunstleve

committed

Shuffling existing TEST_CASEs into systematic matrix.

Ralf W. Grosse-Kunstleve

committed

Implementing all [S]uccess tests.

Ralf W. Grosse-Kunstleve

committed

Implementing all [E]xception tests.

Ralf W. Grosse-Kunstleve

committed

Testing of exceptions not covered by the from-as matrix.

Ralf W. Grosse-Kunstleve

committed

Adding top-level comment.

Ralf W. Grosse-Kunstleve

committed

Converting from methods to factory functions (no functional change).

Ralf W. Grosse-Kunstleve

committed

Removing obsolete and very incomplete test (replaced by Catch2-based test).

Ralf W. Grosse-Kunstleve

committed

Removing stray file.

Ralf W. Grosse-Kunstleve

committed

Adding type_caster_bare_interface_demo.

Ralf W. Grosse-Kunstleve

committed

Adding shared_ptr<mpty>, shared_ptr<mpty const> casters.

Ralf W. Grosse-Kunstleve

committed

Adding unique_ptr<mpty>, unique_ptr<mpty const> casters.

Ralf W. Grosse-Kunstleve

committed

Pure copy of `class class_` implementation in pybind11.h (master commit `98f1bbb`).

Ralf W. Grosse-Kunstleve

committed

classh.h: renaming of class_ to classh + namespace; forking test_classh_wip from test_type_caster_bare_interface_demo.

Ralf W. Grosse-Kunstleve

committed

Hard-coding smart_holder into classh.

Ralf W. Grosse-Kunstleve

committed

Adding mpty::mtxt string member.

Ralf W. Grosse-Kunstleve

committed

Adding isinstance<mpty> in type_caster::load functions.

Ralf W. Grosse-Kunstleve

committed

Adding rvalue_ref, renaming const_value_ref to lvalue_ref & removing const.

Ralf W. Grosse-Kunstleve

committed

Retrieving smart_holder pointer in type_caster<mpty>::load, and using it cast_op operators.

Ralf W. Grosse-Kunstleve

committed

Factoring out smart_holder_type_caster_load.

Ralf W. Grosse-Kunstleve

committed

Retrieving smart_holder pointer in type_caster<std::shared_ptr<mpty[ const]>>::load, and using it cast_op operators.

Ralf W. Grosse-Kunstleve

committed

Improved error messaging: Cannot disown nullptr (as_unique_ptr).

Ralf W. Grosse-Kunstleve

committed

Retrieving smart_holder pointer in type_caster<std::unique_ptr<mpty[ const]>>::load, and using it cast_op operators.

Ralf W. Grosse-Kunstleve

committed

Pure `clang-format --style=file -i` change.

Ralf W. Grosse-Kunstleve

committed

Pure `clang-format --style=file -i` change, with two `clang-format off` directives.

Ralf W. Grosse-Kunstleve

committed

Fixing oversight (discovered by flake8).

Ralf W. Grosse-Kunstleve

committed

flake8 cleanup

Ralf W. Grosse-Kunstleve

committed

Systematically setting mtxt for all rtrn_mpty_* functions (preparation, the values are not actually used yet).

Ralf W. Grosse-Kunstleve

committed

static cast handle for rtrn_cptr works by simply dropping in code from type_caster_base (marked with comments).

Ralf W. Grosse-Kunstleve

committed

static cast handle for rtrn_cref works by simply dropping in code from type_caster_base (marked with comments). rtrn_mref and rtrn_mptr work via const_cast (to add const).

Ralf W. Grosse-Kunstleve

committed

static cast handle for rtrn_valu works by simply dropping in code from type_caster_base (marked with comments). rtrn_rref raises a RuntimeError, to be investigated.

Ralf W. Grosse-Kunstleve

committed

Copying type_caster_generic::cast into type_caster<mpty> as-is (preparation for handling smart pointers).

Ralf W. Grosse-Kunstleve

committed

Pure clang-format change (applied to original type_caster_generic::cast).

Ralf W. Grosse-Kunstleve

committed

Adding comment re potential use_count data race.

Ralf W. Grosse-Kunstleve

committed

static handle cast implementations for rtrn_shmp, rtrn_shcp.

Ralf W. Grosse-Kunstleve

committed

Adding MISSING comments in operator std::unique_ptr<mpty[ const]>.

Ralf W. Grosse-Kunstleve

committed

static handle cast implementations for rtrn_uqmp, rtrn_uqcp.

Ralf W. Grosse-Kunstleve

committed

Bug fix: vptr_deleter_armed_flag_ptr has to live on the heap.

Ralf W. Grosse-Kunstleve

committed

Fixing bugs discovered by ASAN. The code is now ASAN, MSAN, UBSAN clean.

Ralf W. Grosse-Kunstleve

committed

Making test_type_caster_bare_interface_demo.cpp slightly more realistic, ASAN, MSAN, UBSAN clean.

Ralf W. Grosse-Kunstleve

committed

Calling deregister_instance after disowning via unique_ptr.

Ralf W. Grosse-Kunstleve

committed

Removing enable_shared_from_this stub, simplifying existing code, clang-format.

Ralf W. Grosse-Kunstleve

committed

Cosmetical change around helper functions.

Ralf W. Grosse-Kunstleve

committed

Using type_caster_base<mpty>::src_and_type directly, removing copy. Also renaming one cast to cast_const_raw_ptr, for clarity.

Ralf W. Grosse-Kunstleve

committed

Fixing clang-format oversight.

Ralf W. Grosse-Kunstleve

committed

Using factored-out make_constructor (PR pybind#2798 ), removing duplicate code.

Ralf W. Grosse-Kunstleve

committed

Inserting additional assert to ensure a returned unique_ptr is always a new Python instance.

Ralf W. Grosse-Kunstleve

committed

Adding minor comment (change to internals needed to distinguish uninitialized/disowned in error message).

Ralf W. Grosse-Kunstleve

committed

Factoring out find_existing_python_instance().

Ralf W. Grosse-Kunstleve

committed

Moving factored-out make_constructor to test_classh_wip.cpp, restoring previous version of cast.h. This is currently the most practical approach. See PR pybind#2798 for background.

Ralf W. Grosse-Kunstleve

committed

Copying classh type_casters from test_classh_wip.cpp UNMODIFIED, as a baseline for generalizing the code.

Ralf W. Grosse-Kunstleve

committed

Using pybind11/detail/classh_type_casters.h from test_classh_wip.cpp.

Ralf W. Grosse-Kunstleve

committed

Adding & using PYBIND11_CLASSH_TYPE_CASTERS define.

Ralf W. Grosse-Kunstleve

committed

Adding test_classh_inheritance, currently failing (passes with class_).

Ralf W. Grosse-Kunstleve

committed

Removing .clang-format before git rebase master (where the file was added).

Ralf W. Grosse-Kunstleve

committed

Bringing back .clang-format, the previous rm was a bad idea.

Ralf W. Grosse-Kunstleve

committed

Folding in modified_type_caster_generic_load_impl, just enough to pass test_class_wip. test_classh_inheritance is still failing, but with a different error: [RuntimeError: Incompatible type (as_raw…

Ralf W. Grosse-Kunstleve

committed

Minimal changes needed to pass test_classh_inheritance.

Ralf W. Grosse-Kunstleve

committed

First pass adjusting try_implicit_casts and try_load_foreign_module_local to capture loaded_v_h, but untested and guarded with pybind11_failure("Untested"). This was done mainly to determine genera…

Ralf W. Grosse-Kunstleve

committed

Decoupling generic_type from type_caster_generic.

Ralf W. Grosse-Kunstleve

committed

Changes and tests covering classh_type_casters try_implicit_casts.

Ralf W. Grosse-Kunstleve

committed

Minimal test covering classh_type_casters load_impl Case 2b.

Ralf W. Grosse-Kunstleve

committed

Removing stray isinstance<T>(src): it interferes with the py::module_local feature. Adding missing #includes.

Ralf W. Grosse-Kunstleve

committed

Tests for classh py::module_local() feature.

Ralf W. Grosse-Kunstleve

committed

Pure renaming of function names in test_classh_inheritance, similar to the systematic approach used in test_class_wip. NO functional changes.

Ralf W. Grosse-Kunstleve

committed

Pure renaming of function and variable names, for better generalization when convoluting with inheritance. NO functional changes.

Ralf W. Grosse-Kunstleve

committed

Adopting systematic naming scheme from test_classh_wip. NO functional changes.

Ralf W. Grosse-Kunstleve

committed

Moving const after type name, for functions that cover a systematic scheme. NO functional changes.

Ralf W. Grosse-Kunstleve

committed

Adding smart_holder_type_caster_load::loaded_as_shared_ptr, currently bypassing smart_holder shared_ptr tracking completely, but the tests pass and are sanitizer clean.

Ralf W. Grosse-Kunstleve

committed

Removing rtti_held from smart_holder. See updated comment.

Ralf W. Grosse-Kunstleve

committed

Cleaning up loaded_as_raw_ptr_unowned, loaded_as_shared_ptr.

Ralf W. Grosse-Kunstleve

committed

Factoring out convert_type and folding into loaded_as_unique_ptr.

Ralf W. Grosse-Kunstleve

committed

Folding convert_type into lvalue_ref and rvalue_ref paths. Some smart_holder_type_caster_load cleanup.

Ralf W. Grosse-Kunstleve

committed

Using unique_ptr in local_load to replace static variable. Also adding local_load_safety_guard.

Ralf W. Grosse-Kunstleve

committed

Converting test_unique_ptr_member to using classh: fully working, ASAN, MSAN, UBSAN clean.

Ralf W. Grosse-Kunstleve

committed

Removing debugging comments (GET_STACK, GET_INT_STACK). cast.h is identical to current master again, pybind11.h only has the generic_type::initialize(..., &type_caster_generic::local_load) change.

Ralf W. Grosse-Kunstleve

committed

Purging obsolete pybind11/vptr_holder.h and associated test.

Ralf W. Grosse-Kunstleve

committed

Moving several tests to github.com/rwgk/rwgk_tbx/tree/main/pybind11_tests

Ralf W. Grosse-Kunstleve

committed

Adding py::smart_holder support to py::class_, purging py::classh completely.

Ralf W. Grosse-Kunstleve

committed

Renaming files in include directory, creating pybind11/smart_holder.h.

Ralf W. Grosse-Kunstleve

committed

Renaming all "classh" to "smart_holder" in pybind11/detail/smart_holder_type_casters.h.

Ralf W. Grosse-Kunstleve

committed

Systematically renaming tests to use "class_sh" in the name.

Ralf W. Grosse-Kunstleve

committed

Renaming test_type_caster_bare_interface_demo to test_type_caster_bare_interface.

Ralf W. Grosse-Kunstleve

committed

Renaming new tests/core subdirectory to tests/pure_cpp.

Ralf W. Grosse-Kunstleve

committed

Adding new tests to CMake config, resetting CI config.

Ralf W. Grosse-Kunstleve

committed

Changing CMake file so that test_class_sh_module_local.py actually runs.

Ralf W. Grosse-Kunstleve

committed

clang-tidy fixes.

Ralf W. Grosse-Kunstleve

committed

32-bit compatibility.

Ralf W. Grosse-Kunstleve

committed

Reusing type_caster_base make_copy_constructor, make_move_constructor with a trick.

Ralf W. Grosse-Kunstleve

committed

CMake COMPARE NATURAL is not available with older versions.

Ralf W. Grosse-Kunstleve

committed

Adding copyright notices to new header files.

Ralf W. Grosse-Kunstleve

committed

Explicitly define copy/move constructors/assignments.

Ralf W. Grosse-Kunstleve

committed

Adding new header files to tests/extra_python_package/test_files.py.

Ralf W. Grosse-Kunstleve

committed

Adding tests/pure_cpp/CMakeLists.txt.

Ralf W. Grosse-Kunstleve

committed

Making use of the new find_existing_python_instance() function factored out with PR pybind#2822 .

Ralf W. Grosse-Kunstleve

committed

Moving define PYBIND11_SMART_HOLDER_TYPE_CASTERS(T) down in the file. NO functional changes. Preparation for follow-up work (to keep that diff smaller).

Ralf W. Grosse-Kunstleve

committed

Reintroducing py::classh, this time as a simple alias for py::class_<U, py::smart_holder>.

Ralf W. Grosse-Kunstleve

committed

Replacing detail::is_smart_holder<H> in cast.h with detail::is_smart_holder_type_caster<T>.

Ralf W. Grosse-Kunstleve

committed

Fixing oversight.

Ralf W. Grosse-Kunstleve

committed

Adding classu alias for class_<U, std::unique_ptr<U>>.

Ralf W. Grosse-Kunstleve

committed

Giving up on idea to use legacy init_instance only if is_base_of<type_caster_generic, type_caster<T>. There are use cases in the wild that define both a custom type_caster and class_.

Ralf W. Grosse-Kunstleve

committed

Removing test_type_caster_bare_interface, which was moved to the separate PR pybind#2834 .

Ralf W. Grosse-Kunstleve

committed

Moving up is_smart_holder_type_caster, to also use in cast_is_temporary_value_reference.

Ralf W. Grosse-Kunstleve

committed

Adding smart_holder_type_casters for unique_ptr with custom deleter. SEVERE CODE DUPLICATION. This commit is to establish a baseline for consolidating the unique_ptr code.

Ralf W. Grosse-Kunstleve

committed

Unification of unique_ptr, unique_ptr_with_deleter code in smart_holder_poc.h. Leads to more fitting error messages. Enables use of unique_ptr<T, D> smart_holder_type_casters also for unique_ptr<T>.

Ralf W. Grosse-Kunstleve

committed

Copying files as-is from branch test_unique_ptr_member (PR pybind#2672 ).

Ralf W. Grosse-Kunstleve

committed

Adding comment, simplifying naming, cmake addition.

Ralf W. Grosse-Kunstleve

committed

Introducing PYBIND11_USE_SMART_HOLDER_AS_DEFAULT macro (tested only undefined; there are many errors with the macro defined).

Ralf W. Grosse-Kunstleve

committed

Removing test_type_caster_bare_interface, which was moved to the separate PR pybind#2834 .

Ralf W. Grosse-Kunstleve

committed

Fixing oversight introduced with commit `95425f1`.

Ralf W. Grosse-Kunstleve

committed

Setting record.default_holder correctly for PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.

Ralf W. Grosse-Kunstleve

committed

Fixing up cast.h and smart_holder.h after rebase.

Ralf W. Grosse-Kunstleve

committed

Removing detail/smart_holder_type_casters.h in separate commit.

Ralf W. Grosse-Kunstleve

committed

Commenting out const in def_buffer(... const). With this, test_buffers builds and runs with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. Explanation why the const needs to be removed, or fix elsewhere, is…

Ralf W. Grosse-Kunstleve

committed

Adding test_class_sh_factory_constructors, reproducing test_factory_constructors failure. Using py::class_ in this commit, to be changed to py::classh for debugging.

Ralf W. Grosse-Kunstleve

committed

Removing include/pybind11/detail/smart_holder_type_casters.h from CMakeLists.txt, test_files.py (since it does not exist in this branch).

Ralf W. Grosse-Kunstleve

committed

Adding // DANGER ZONE reminders.

Ralf W. Grosse-Kunstleve

committed

Converting as many py::class_ to py::classh as possible, not breaking tests.

Ralf W. Grosse-Kunstleve

committed

Adding initimpl::construct() overloads, resulting in test_class_sh_factory_constructors feature parity for py::class_ and py::classh.

Ralf W. Grosse-Kunstleve

committed

Adding enable_if !is_smart_holder_type_caster to existing initimpl::construct(). With this test_factory_constructors.cpp builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.

Ralf W. Grosse-Kunstleve

committed

Disabling shared_ptr&, shared_ptr* tests when building with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT for now, pending work on smart_holder_type_caster<shared_ptr>.

Ralf W. Grosse-Kunstleve

committed

Factoring out struct and class definitions into anonymous namespace. Preparation for building with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT.

Ralf W. Grosse-Kunstleve

committed

Simplifying from_unique_ptr(): typename D = std::default_delete<T> is not needed. Factoring out is_std_default_delete<T>() for consistentcy between ensure_compatible_rtti_uqp_del() and from_unique_…

Ralf W. Grosse-Kunstleve

committed

Introducing PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS. Using it in test_smart_ptr.cpp. With this test_smart_ptr builds with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT and all but one test run successfully.

Ralf W. Grosse-Kunstleve

committed

Introducing 1. type_caster_for_class_, used in PYBIND11_MAKE_OPAQUE, and 2. default_holder_type, used in stl_bind.h.

Ralf W. Grosse-Kunstleve

committed

Using __VA_ARGS__ in PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS.

Ralf W. Grosse-Kunstleve

committed

Replacing condense_for_macro with much simpler approach.

Ralf W. Grosse-Kunstleve

committed

Softening static_assert, to only check specifically that smart_holder is not mixed with type_caster_base, and unique_ptr/shared_ptr holders are not mixed with smart_holder_type_casters.

Ralf W. Grosse-Kunstleve

committed

Adding PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS in test_class.cpp (with this all but one test succeed with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT).

Ralf W. Grosse-Kunstleve

committed

Adding remaining PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS. static_assert for "necessary conditions" for both types of default holder, static_assert for "strict conditions" guarded by new PYBIND11…

Ralf W. Grosse-Kunstleve

committed

Introducing check_is_smart_holder_type_caster() function for runtime check, and reinterpreting record.default_holder as "uses_unique_ptr_holder". With this test_smart_ptr succeeds. (All 42 tests bu…

Ralf W. Grosse-Kunstleve

committed

Bug fix: Adding have_value() to smart_holder_type_caster_load. With this test_builtin_casters succeeds. (All 42 tests build, 36 tests succeed, 5 run but have some failures, 1 segfault.)

Ralf W. Grosse-Kunstleve

committed

Adding unowned_void_ptr_from_direct_conversion to modified_type_caster_generic_load_impl. This fixes the last remaining segfault (test_numpy_dtypes). New stats for all tests combined: 12 failed, 45…

Ralf W. Grosse-Kunstleve

committed

Adding "Lazy allocation for unallocated values" (for old-style init) into load_value_and_holder. Deferring destruction of disowned holder until clear_instance, to remain inspectable for "uninit…

Ralf W. Grosse-Kunstleve

committed

Changing std::shared_ptr pointer/reference to const pointer/reference. New stats for all tests combined: 4 failed, 466 passed.

Ralf W. Grosse-Kunstleve

committed

Adding return_value_policy::move to permissible policies for unique_ptr returns. New stats for all tests combined: 3 failed, 467 passed.

Ralf W. Grosse-Kunstleve

committed

Overlooked flake8 fixes.

Ralf W. Grosse-Kunstleve

committed

Manipulating failing ConstructorStats test to pass, to be able to run all tests with ASAN.

Ralf W. Grosse-Kunstleve

committed

Adding copy constructor and move constructor tracking to atyp. Preparation for a follow-up change in smart_holder_type_caster, to make this test sensitive to the changing behavior.

Ralf W. Grosse-Kunstleve

committed

Removing `operator T&&() &&` from smart_holder_type_caster, for compatibility with the behavior of type_caster_base. Enables reverting 2 of 3 test manipulations applied under commit `249df7c`. The ma…

Ralf W. Grosse-Kunstleve

committed

Fixing unfortunate editing mishap. This reverts the last remaining test manipulation in commit `249df7c` and makes all existing unit tests pass with smart_holder as default holder.

Ralf W. Grosse-Kunstleve

committed

GitHub CI clang-tidy fixes.

Ralf W. Grosse-Kunstleve

committed

Adding messages to terse `static_assert`s, for pre-C++17 compatibility.

Ralf W. Grosse-Kunstleve

committed

Using @pytest.mark.parametrize to run each assert separately (to see all errors, not just the first).

Ralf W. Grosse-Kunstleve

committed

Systematically removing _atyp from function names, to make the test code simpler.

Ralf W. Grosse-Kunstleve

committed

Using re.match to accommodate variable number of intermediate MvCtor.

Ralf W. Grosse-Kunstleve

committed

Also removing `operator T()` from smart_holder_type_caster, to fix gcc compilation errors. The only loss is pass_rref in test_class_sh_basic.

Ralf W. Grosse-Kunstleve

committed

Systematically replacing `detail::enable_if_t<...smart_holder...>` with `typename std::enable_if<...smart_holder...>::type`. Attempt to work around MSVC 2015 issues, to be tested via GitHub CI. The…

Ralf W. Grosse-Kunstleve

committed

Importing re before pytest after observing a PyPy CI flake when importing pytest first.

Ralf W. Grosse-Kunstleve

committed

Copying MSVC 2015 compatibility change from branch pr2672_use_smart_holder_as_default.

Ralf W. Grosse-Kunstleve

committed

Introducing is_smart_holder_type_caster_base_tag, to keep smart_holder code more disconnected.

Ralf W. Grosse-Kunstleve

committed

Working around MSVC 2015 bug.

Ralf W. Grosse-Kunstleve

committed

Expanding comment for MSVC 2015 workaround.

Ralf W. Grosse-Kunstleve

committed

Systematically changing std::enable_if back to detail::enable_if_t, effectively reverting commit `5d4b689`.

Ralf W. Grosse-Kunstleve

committed

Removing unused smart_holder_type_caster_load::loaded_as_rvalue_ref (it was an oversight that it was not removed with commit `23036a4`).

Ralf W. Grosse-Kunstleve

committed

Removing py::classu, because it does not seem useful enough.

Ralf W. Grosse-Kunstleve

committed

Reverting commit `6349531` by un-commenting `const` in `def_buffer(...)`. To make this possible, `operator T const&` and `operator T const*` in `smart_holder_type_caster` need to be marked as `const`…

Ralf W. Grosse-Kunstleve

committed

Adding construct() overloads for constructing smart_holder from alias unique_ptr, shared_ptr returns.

Ralf W. Grosse-Kunstleve

committed

Adding test_class_sh_factory_constructors.cpp to tests/CMakeLists.txt (fixes oversight, this should have been added long before).

Ralf W. Grosse-Kunstleve

committed

Compatibility with old clang versions (clang 3.6, 3.7 C++11).

Ralf W. Grosse-Kunstleve

committed

Cleaning up changes to existing unit tests.

Ralf W. Grosse-Kunstleve

committed

Systematically adding SMART_HOLDER_WIP tag. Removing minor UNTESTED tags (only the throw are not actually exercised, investing time there has a high cost but very little benefit).

Ralf W. Grosse-Kunstleve

committed

Splitting out smart_holder_type_casters again, into new detail/smart_holder_type_casters_inline_include.h.

Ralf W. Grosse-Kunstleve

committed

Splitting out smart_holder_init_inline_include.h.

Ralf W. Grosse-Kunstleve

committed

Adding additional new include files to CMakeLists.txt, tests/extra_python_package/test_files.py.

Ralf W. Grosse-Kunstleve

committed

clang-format cleanup of most smart_holder code.

Ralf W. Grosse-Kunstleve

committed

Adding source code comments in response to review.

Ralf W. Grosse-Kunstleve

committed

Simple micro-benchmark ("ubench") comparing runtime performance for several holders.

Ralf W. Grosse-Kunstleve

committed

Breaking out number_bucket.h, adding hook for also collecting performance data for PyCLIF.

Ralf W. Grosse-Kunstleve

committed

Accounting for ubench in MANIFEST.in (simply prune, for now).

Ralf W. Grosse-Kunstleve

committed

Smarter determination of call_repetitions.

Ralf W. Grosse-Kunstleve

committed

Also scaling performance data to PyCLIF.

Ralf W. Grosse-Kunstleve

committed

Adding ubench/python/number_bucket.clif here for general visibility.

Ralf W. Grosse-Kunstleve

committed

Fix after rebase

Ralf W. Grosse-Kunstleve

committed

Merging detail/smart_holder_init_inline_include.h into detail/init.h.

Ralf W. Grosse-Kunstleve

committed

Renaming detail/is_smart_holder_type_caster.h -> detail/smart_holder_sfinae_hooks_only.h.

Ralf W. Grosse-Kunstleve

committed

Renaming is_smart_holder_type_caster -> type_uses_smart_holder_type_caster for clarity.

Ralf W. Grosse-Kunstleve

committed

Renaming type_caster_type_is_smart_holder_type_caster -> wrapped_type_uses_smart_holder_type_caster for clarity.

Ralf W. Grosse-Kunstleve

committed

Renaming is_smart_holder_type_caster_base_tag -> smart_holder_type_caster_base_tag for simplicity.

Ralf W. Grosse-Kunstleve

committed

Adding copyright notices and minor colateral cleanup.

Ralf W. Grosse-Kunstleve

committed

Commits

Commits on Feb 23, 2021