Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Show edge case with operator overloading, reversal, and mixing #2513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Sep 19, 2020

Trying to show issue I encountered in:
RobotLocomotion/drake#14098
Here:
https://github.com/RobotLocomotion/drake/blob/5369d2ead17312db6172de52a969ce7172532670/bindings/pydrake/multibody/math_py.cc#L71-L79

However, this test passes, so some possible issues with my repro (on a pybind11 fork):

  • In Drake, I implement __matmul__ by simply aliasing multiply, so perhaps pybind11 has some magic that helps it disambiguate?
  • In Drake, I just use the operators directly, so perhaps pybind11 has some magic?
  • pybind11 has gotten a fix that Drake's pybind11 fork hasn't absorbed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant