Skip to content

Commit

Permalink
Adding link to PR #2644. Pushing directly for this minor addition to …
Browse files Browse the repository at this point in the history
…the documentation.
  • Loading branch information
Ralf W. Grosse-Kunstleve committed Apr 22, 2021
1 parent 91e81b0 commit c169a5e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion README_smart_holder.rst
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,9 @@ but not the more general holder mismatch issue. — Unfortunately the existing
pybind11 internals do not track holder runtime type information, therefore
the holder mismatch issue cannot be solved in a fashion that would allow
an incremental transition, which is the whole point of the Conservative
mode. Please proceed with caution.
mode. Please proceed with caution. (See `PR #2644
<https://github.com/pybind/pybind11/pull/2644>`_ for background, which is
labeled with "abi break".)

Another pitfall worth pointing out specifically, although it follows
from the previous: mixing base and derived classes between Classic and
Expand Down

0 comments on commit c169a5e

Please sign in to comment.