Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get labels from issue metadata #189

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Jul 12, 2024

Fix: #188

sorta self explanatory, we can keep the whole Issue object if we want, i just figure we sorta want to keep the review yaml tidy-ish and wasn't sure if we would want to use any of those other fields. if we want it it would just be a matter of removing the validator and changing the field type.

@lwasser
Copy link
Member

lwasser commented Jul 12, 2024

This also works great! thank you again. I see the label names now in the issue object.
i'm still wrapping my head around using Field and mutable vs immutable objects!! merging.

@lwasser lwasser merged commit c1bf16a into pyOpenSci:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: Review model should include labels (OR is there a better way to access labels)?
2 participants