Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add test coverage #107

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Fix: add test coverage #107

merged 9 commits into from
Feb 26, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Feb 25, 2024

closes #97

Setup codecov. for some reason i can generate an in terminal report but rendered reports are failing for me locally. but all of the other pieces are setup for this to work

Setup codecov - reports not currently working

Fix: cod coverage issue is 9
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov action just released to 4.0.2

.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
@lwasser lwasser marked this pull request as ready for review February 25, 2024 19:59
Copy link

codecov bot commented Feb 25, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@lwasser
Copy link
Member Author

lwasser commented Feb 25, 2024

yay it's working ✨ thanks for the cod cov update @willingc let's merge this puppy and soon we will be on en route towards fearless refactoring! 🚀

i keep forgetting that you can setup various hatch scripts and i have a few options setup for us to use. actually before i merge i'll document that

development.md Outdated Show resolved Hide resolved
@willingc willingc merged commit b3fae4e into pyOpenSci:main Feb 26, 2024
2 checks passed
@willingc
Copy link
Collaborator

Excellent work @lwasser 🎉 I'm merging. If there is further doc stuff, let's do that in a new PR. 🐶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enh: Setup code cov to test coverage
2 participants