Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optional dependencies and edit pyproject.toml #104

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

willingc
Copy link
Collaborator

This PR adds dev dependencies as optional dependencies and makes minor style changes.

Developers can now run pip install ".[dev]" or pip install -e ".[dev]" to install dev tools locally.

We can set up a dev environment for hatch in a separate PR.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. let's merge this. @willingc when we merge the tests PR, you'll notice i setup a hatch environment to run tests. We can actually setup a lint environment too or a general dev environment as well.

this is where we'll learn that using hatch - there is a slightly different approach in terms of environments. i'm actually really enjoying it the more i use it. because you don't HAVE to worry about what environment you are in. the only thing i don't understand how to do is run debugging actions in my GUI (vscode). i may ask about that at some point but that will be a bit of a workflow change. in the meantime, let's keep this approach as an option and merge it! perhaps some won't want to use hatch to do their dev work and that is also OK.

@lwasser lwasser merged commit fe96d53 into pyOpenSci:main Feb 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants