Skip to content

Commit

Permalink
Fix: cleanup comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lwasser committed Feb 25, 2024
1 parent 03df5ba commit 042fcb5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
9 changes: 2 additions & 7 deletions src/pyosmeta/cli/process_reviews.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@

# TODO: if we export files we might want packages.yml and then under_review.yml
# thus we'd want to add a second input parameters which was file_name
# TODO: feature - Would be cool to create an "under review now" list as well -
# ideally this could be passed as a CLI argument with the label we want to
# search for
# TODO: feature - Create an "under review now" list as well

import pickle

Expand All @@ -35,9 +33,7 @@ def main():
# Get all issues for approved packages - load as dict
issues = process_review.return_response()
# TODO: this method parse_issue_header is working but the parsing code is
# really hard to follow
# It is worth another pr that cleans up the workflow around grabbing
# metadata so it's clearer to follow.
# hard to follow
accepted_reviews = process_review.parse_issue_header(issues, 45)

# Update gh metrics via api for all packages
Expand All @@ -47,7 +43,6 @@ def main():
)

# Populate model objects with review data + metrics
# TODO: all_reviews contains a bunch of extra mess that it doesn't need
final_reviews = {}
for key, review in all_reviews.items():
# First add gh meta to each dict
Expand Down
12 changes: 6 additions & 6 deletions src/pyosmeta/parse_issues.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,15 +458,15 @@ def parse_issue_header(
body_data, "## Scope", 10
)
# NOTE: right now the numeric value is hard coded based on the
# number of partners listed in the issue. so it assumes there is
# 3 partners. but that might not always be the case so we should
# add a check in case there are fewer or more partners (if someone
# modifies the template which they tend to do OR if it's an older
# template)
# TODO: rather than exact match have the line start_with the string
# number of categories listed in the issue template.
# this could be made more flexible if it just runs until it runs
# out of categories to parse
review[pkg_name]["partners"] = self.get_categories(
body_data, "## Community Partnerships", 3
)
# TODO: the current workflow will not parse domains
# add a separate workflow to parse domains and add them to the
# categories list
# review[pkg_name]["domains"] = self.get_categories(body_data,
# '## Domains',
# 3)
Expand Down

0 comments on commit 042fcb5

Please sign in to comment.