-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling on index.md and readme.md #1184
Correct spelling on index.md and readme.md #1184
Conversation
Thank you @kuth-chi for fixing those spelling mistakes! |
I would like to contribute more like Khmer default font in FPDF2 is not the most using in Khmer because it's difficult to read. Can I added default font? |
Hi @kuth-chi
In issue #700, you mentioned using the Battambang font. Is it the one difficult to read? What do you mean by "default font" ? |
Currently FPDF2 has no default Khmer font right? For Khmer characters will be display base on System or user manual adding. |
fpdf2 does not have a concept of "default fonts" at all. In all cases, the user needs to specify which font to use, either directly through We don't really want to recommend (let alone discourage) the use of any specific font, since this is largely a matter of opinion and taste. In "docs/Unicode.md" we list a few places where font files can be found. We could add a section there about where to find fonts for "exotic" languages that are difficult to find in the general collections. If you know one or two good places where to find khmer fonts, then that would certainly be helpful information for such a section. Ideally those would be directories of fonts, so we don't need to update individual links too often. |
I have post on issue #1187 Please check for detail. |
e.g. Fixes #0
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.