Several updates/fixes to project's CI #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDrike
force-pushed
the
update-ci
branch
3 times, most recently
from
a251811 to
859c8e1
Compare
ItsDrike
force-pushed
the
update-ci
branch
3 times, most recently
from
1c52996 to
aba9fb3
Compare
This code hurts to write and to look at. But well, it makes pytest work, what can you do...
Merged
Using the `::set-output` syntax in stdout is deprecated.
ItsDrike
added
t: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues with the current github workflows, and makes several improvements / updates to bring them up to date with standards or to simplify them.
Note: This PR fixes previously broken Python 3.8 support for the library. (Further explained below)
For some reason, I apparently just hard-coded the python version, even though the CI was running in a matrix, this was missleading, as it lead to the tests never actually running on python 3.8. Over time, this has resulted in some issues and the code wans't actually even runnable on 3.8. This PR also fixes these issues.
The original workflows were still using 3.11 as the latest python version.
This allows for easier set up of required workflows for the repo, and unifies some logic, like concurrency config, hence reducing code repetition.
Made possible because of the workflow unification. This change reduces the amount of spam in the discord channel with github hooks, as we don't need to see the status of both validation and unit-tests separately, it is more than enough to just have it send back a final status of the unified workflow.
After a recent change made to the project, the code that was uploading a workflow artifact with the PR data has been removed by accident, this adds the code back, this time into the new unified CI workflow.
P.S.: The code to make tests runnable on 3.8 is incredibly cursed, but the version will be dropped some time this year, so it's not a huge issue and it is only affecting the tests code, this logic doesn't touch any of the public library code.