Skip to content

Commit

Permalink
Use codeclimate reporter id from gh secrets
Browse files Browse the repository at this point in the history
Even though codeclimate doesn't consider the reporter id to be secret,
as it doesn't allow accessing any sensitive information and it's
write-only, it's still possible to use this id to maliciously upload
coverage from other projects as coverage for this project.

There isn't much of a reason why anyone would want to do this, all it
would achieve is potentially messing up the project status page that
shows the coverage score. But just the fact that this is possible is
still uncomfortable in my opinion.

For that reason, the coverage id for this project has been regenerated
and moved to github secrets.
  • Loading branch information
ItsDrike committed Jul 13, 2024
1 parent f785eff commit 68e44a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Upload coverage to codeclimate
uses: paambaati/[email protected]
env:
CC_TEST_REPORTER_ID: 0ec6191ea237656410b90dded9352a5b16d68f8d86d60ea8944abd41d532e869
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
with:
coverageLocations: .coverage.xml:coverage.py

Expand Down

0 comments on commit 68e44a0

Please sign in to comment.