Add docsLink for groupedValidation results

pwa-builder · Aug 11, 2023 · bb250d1 · bb250d1
1 parent cf63197
commit bb250d1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/libraries/manifest-validation/package-lock.json b/libraries/manifest-validation/package-lock.json
diff --git a/libraries/manifest-validation/package.json b/libraries/manifest-validation/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pwabuilder/manifest-validation",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "author": "pwa-builder",
   "license": "ISC",
   "description": "Manifest validation library by PWABuilder criteria",

diff --git a/libraries/manifest-validation/src/index.ts b/libraries/manifest-validation/src/index.ts
@@ -128,7 +128,7 @@ export async function groupedValidation(manifest: Manifest): Promise<TokensValid
         currentManifest = manifest;
         const testResults = await loopThroughKeys(manifest, false, true);
         const resultsGrouped = testResults.reduce((acc, curr) => {
-            const curTrimmed = { category: curr.category, member: curr.member, valid: curr.valid, displayString: curr.displayString, errorString: curr.errorString, infoString: curr.infoString };
+            const curTrimmed = { category: curr.category, member: curr.member, valid: curr.valid, displayString: curr.displayString, errorString: curr.errorString, infoString: curr.infoString, docsLink: curr.docsLink };
             if (acc[curr.member]) {
                 acc[curr.member].push(curTrimmed);
             } else {

diff --git a/libraries/manifest-validation/src/interfaces.ts b/libraries/manifest-validation/src/interfaces.ts
@@ -18,6 +18,7 @@ export type PartialValidation = {
     displayString?: string;
     errorString?: string;
     infoString?: string;
+    docsLink?: string;
     valid: boolean;
 }
 

diff --git a/libraries/manifest-validation/test/validation-tests.mjs b/libraries/manifest-validation/test/validation-tests.mjs
@@ -92,7 +92,7 @@ describe('Manifest Validation with hardcoded test manifest', async () => {
   });
 
   // should fail because of missing 96x96 icon
-  it('Can validate the inner structure of shortcuts, should fail', async () => {
+  it('Can validate the inner structure of shortcuts', async () => {
     const validity = await maniLib.validateSingleField("shortcuts", [
       {
         "name": "Start Live Session",
@@ -103,7 +103,7 @@ describe('Manifest Validation with hardcoded test manifest', async () => {
       }
     ]);
 
-    assert.equal(validity.valid, false);
+    assert.equal(validity.valid, true);
   });
 
   it('start_url is within app scope, should pass', async () => {