Skip to content

Commit

Permalink
Staging (#4193)
Browse files Browse the repository at this point in the history
fixes #[issue number] 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->


## Describe the new behavior?


## PR Checklist

- [ ] Test: run `npm run test` and ensure that all tests pass
- [ ] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ ] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Nikola Metulev <[email protected]>
Co-authored-by: Gleb Khmyznikov <[email protected]>
Co-authored-by: Mara'ah Lee <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adolf Daniel <[email protected]>
Co-authored-by: Justin Willis (HE / HIM) <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: Beth Pan <[email protected]>
Co-authored-by: vipul-bhojwani <[email protected]>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Federico Navarrete <[email protected]>
Co-authored-by: Toby Liu <[email protected]>
  • Loading branch information
15 people authored Jul 19, 2023
1 parent af9cb9d commit 8b20cb4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion apps/pwabuilder/src/script/pages/app-report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export class AppReport extends LitElement {
},
{"messages": {
"green": "PWABuilder has analyzed your Service Worker and your Service Worker is ready for packaging! Great job you have a perfect score!",
"yellow": "PWABuilder has analyzed your Service Worker, and has identified additonal features you can add, like offline support, to make your app feel more robust.",
"yellow": "PWABuilder has analyzed your Service Worker, and has identified additional features you can add, like offline support, to make your app feel more robust.",
"blocked": "",
"none": "PWABuilder has analyzed your site and did not find a Service Worker. Having a Service Worker is highly recomeneded by PWABuilder as it enables an array of features that can enhance your PWA. You can generate a Service Worker below or use our documentation to make your own.",
},
Expand Down
5 changes: 3 additions & 2 deletions libraries/manifest-validation/src/mani-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,9 @@ export const maniTests: Array<Validation> = [
return false;
}

// Commenting this block out, this shouldn't be an error but instead a warning.
/* we use every here bc every shortcut needs at
least one icon with size 96x96 no icons at all */
least one icon with size 96x96 no icons at all
const has96x96Icon = value.every((shortcut: {icons?: Icon[]}) => {
if (!shortcut.icons) return true;
// we use some here bc only one icon has to be that size
Expand All @@ -500,7 +501,7 @@ export const maniTests: Array<Validation> = [
if (!has96x96Icon) {
this.errorString = "One or more of your shortcuts has icons but does not have one with size 96x96";
return false;
}
} */

return true;
}
Expand Down

0 comments on commit 8b20cb4

Please sign in to comment.