Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Support for rails 7.1 explicit since 7.2 is there as well #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kronn
Copy link
Member

@kronn kronn commented Oct 23, 2024

No description provided.

@kronn kronn requested a review from codez October 23, 2024 06:59
@codez
Copy link
Contributor

codez commented Oct 24, 2024

Thanks for the PR. While adding the 7.1 Gemfile makes sense, Gemfile.lock should also be updated to 7.2. Otherwise, 7.1 is tested twice, which adds no additional benefits.

Could you also look into that test failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants