censorProjectWarnings in monorepo workspace spago.yaml
#1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisyscanner
commented
Jan 26, 2025
| @@ -975,13 +975,16 @@ $ node -e "import('./index.js').then(m => console.log(m.main))" | |||
| ``` | |||
|
|
|||
| Spago does not wrap the entirety of the bundler's API (esbuild for JS builds), so it's possible to pass arguments through to it. E.g. to exclude an NPM package from the bundle you can pass the `--external` flag to esbuild: | |||
|
|
|||
There was a problem hiding this comment.
My editor auto-formatted this markdown on save - can revert if preferred.
| } | ||
| , toPathDecision | ||
| { pathIsFromPackage: (testPath `Path.isPrefixOf` _) | ||
| , pathType: IsSrc | ||
| , strict: fromMaybe false $ psaCliFlags.strict <|> (package.test >>= _.strict) | ||
| , censorWarnings: package.test >>= _.censorTestWarnings | ||
| , censorWarnings: (package.test >>= _.censorTestWarnings) <|> censorProjectWarnings |
There was a problem hiding this comment.
to discuss I looked into pulling this out into a separate param like censorTestWarnings, but maybe it doesn't make sense having it under buildOpts as this is akin to build: in the package spago.yaml, maybe we'd need testOpts as censorTestWarnings is under test:.
If you get me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1311
Description of the change
Allows
censorProjectWarningsto be specified in a workspaces'sspago.yamland apply to all packages in a workspace.Can override it in a package's own
spago.yamleither toallor[]to censor no warnings for that particular workspace.Checklist:
README