Ensure all packages are included in registry index, even if they have no versions #318
Conversation
thomashoneyman
requested review from
f-f and
colinwahl
and removed request for
f-f
|
Note that the Registry Index is not our source of truth, we just accidentally go through it while legacy-importing - I think that in order to consider #302 fixed we should write empty Metadata files for these packages. This is because "is a Metadata file there?" is our main check for registering a new name, see: |
|
Ah, I see, I was aiming to write empty manifests — I can write the metadata files instead. |
|
@f-f, @colinwahl I've updated this to write reserved package names to the metadata directory. In 33b23b3 I started tracking that directory, but I can revert the change if y'all don't feel ready to track this information or want to wait on #322 before tracking this directory. The change is actually quite small -- just 3 files affected -- so I'd recommend reviewing by filtering only to |
| -- We don't need to preserve any packages that made it through | ||
| -- processing into the resulting registry index. | ||
| guard $ isNothing $ Map.lookup parsedName registryIndex | ||
| { owner, repo } <- hush $ GitHub.parseRepo address |
There was a problem hiding this comment.
I opted to only reserve names for packages that have a valid GitHub repository as well as a valid package name, because that way we can write an empty metadata file for them.
This is acceptable because only one package has a malformed package name (TypeAhead) and it makes sense not to reserve that name (it can't be used anyway), and because zero packages have malformed GitHub URLs so no packages will fail this check.
#322 is about the |
Fixes #302 by ensuring that all packages with a valid package name are included in the registry index during the legacy import process. This does not ensure that these packages are uploaded (we're going to have to decide how we want to do that -- write an empty directory?), and the unused binding will leave a warning active until we have added them to the upload process.