Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support for Prometheus exporters #200

Merged
merged 22 commits into from
Dec 11, 2023

Conversation

ldaneliukas
Copy link
Collaborator

@ldaneliukas ldaneliukas commented Dec 7, 2023

As is now, the chart only accounts for puppetdb-exporter and it does not allow the user to utilize any metrics scraping implementation other than the one provided by the use of monitoring.coreos.com/v1 which is not always the case.

The changes in this PR allow users to choose whether they want a serviceMonitor deployed or not on the account that they might have Prometheus scraping all services/pods/etc via the Kubernetes API.

In addition to that, it adds jmx-exporter which is commonly used to get all of the Puppetserver mbean metrics in the Prometheus format allowing for insightful dashboards/alerts. These exporters are deployed next to each Puppetserver, be it master or compiler. It is up to the user to ensure that the Puppetserver exposes JMX - I've added a comment in the extraEnv that contains an example of it.

Do note that this introduces a breaking change for current users of the metrics: section in values.yaml due to support of multiple exporters, each exporter is nested under an object representing it.


This PR also adds snapshots for all unittests that make it easier catch unexpected changes when editing templates. Note, that this will require updating snapshots when the version is incremented in Chart.yaml too - this is done by running helm unittest ./ -u since the version number is contained within them in all of the resources.


Removing the commented out prometheusRule from values.yaml as it is not really used anywhere even if you were to uncomment it (from what I can tell).

@ldaneliukas ldaneliukas changed the title Add sj; Extend support for Prometheus exporters Dec 7, 2023
Copy link
Contributor

@Xtigyro Xtigyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME work, @ldaneliukas!

@Xtigyro
Copy link
Contributor

Xtigyro commented Dec 11, 2023

@underscorgan @binford2k @AkashChikanep4 @david22swan @ericwilliamson @grimradical

Would you mind please providing @ldaneliukas the same level of permissions in the repo @davidphay has?

@Xtigyro Xtigyro merged commit 649b2ed into puppetlabs:master Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants