-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support for Prometheus exporters #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtigyro
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME work, @ldaneliukas!
@underscorgan @binford2k @AkashChikanep4 @david22swan @ericwilliamson @grimradical Would you mind please providing @ldaneliukas the same level of permissions in the repo @davidphay has? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is now, the chart only accounts for
puppetdb-exporter
and it does not allow the user to utilize any metrics scraping implementation other than the one provided by the use ofmonitoring.coreos.com/v1
which is not always the case.The changes in this PR allow users to choose whether they want a
serviceMonitor
deployed or not on the account that they might have Prometheus scraping all services/pods/etc via the Kubernetes API.In addition to that, it adds
jmx-exporter
which is commonly used to get all of the Puppetserver mbean metrics in the Prometheus format allowing for insightful dashboards/alerts. These exporters are deployed next to each Puppetserver, be it master or compiler. It is up to the user to ensure that the Puppetserver exposes JMX - I've added a comment in theextraEnv
that contains an example of it.Do note that this introduces a breaking change for current users of the
metrics:
section invalues.yaml
due to support of multiple exporters, each exporter is nested under an object representing it.This PR also adds snapshots for all unittests that make it easier catch unexpected changes when editing templates. Note, that this will require updating snapshots when the version is incremented in
Chart.yaml
too - this is done by runninghelm unittest ./ -u
since the version number is contained within them in all of the resources.Removing the commented out
prometheusRule
fromvalues.yaml
as it is not really used anywhere even if you were to uncomment it (from what I can tell).