Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converge all language examples for Github template to use the same output name. #846

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Converge all language examples for Github template to use the same output name. #846

merged 1 commit into from
Oct 17, 2024

Conversation

thoward
Copy link
Contributor

@thoward thoward commented Oct 16, 2024

Fixes #842

@thoward thoward added the kind/enhancement Improvements or new features label Oct 16, 2024
@thoward thoward added this to the 0.111 milestone Oct 16, 2024
@thoward thoward self-assigned this Oct 16, 2024
@thoward thoward mentioned this pull request Oct 16, 2024
Closed
iwahbe
iwahbe approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up here.

@thoward thoward merged commit 352cab1 into master Oct 17, 2024
6 checks passed
@thoward thoward deleted the thoward/github-templates/make-output-value-names-consistent branch October 17, 2024 21:23
@stooj stooj mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

@sean1588 sean1588 sean1588 approved these changes

Assignees

@thoward thoward

Labels
kind/enhancement Improvements or new features
Projects
Docs 📚
Status: 🏁 Done
Milestone
0.111
Development

Successfully merging this pull request may close these issues.

Export name not suitable for github-{yaml,typescript} examples
3 participants
@thoward @sean1588 @iwahbe