Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update container templates to use docker-build provider #820

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Update container templates to use docker-build provider #820

merged 6 commits into from
Aug 21, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Aug 6, 2024 •
edited
Loading

We'd like to update templates to use the newer docker-build provider since it's recommended for building images going forward.

Fixes #814.

@blampe blampe marked this pull request as draft August 6, 2024 20:29
@blampe blampe marked this pull request as ready for review August 7, 2024 19:07
@blampe blampe requested a review from cnunciato August 7, 2024 19:09
@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
@blampe blampe requested a review from a team August 21, 2024 19:00
mjeffryes
mjeffryes approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was surprised by the lack of an AWS version, but it looks like the use of docker is hidden by AWSX lib there.

@blampe blampe enabled auto-merge August 21, 2024 21:53
@blampe blampe merged commit e12d3bb into master Aug 21, 2024
6 checks passed
@blampe blampe deleted the blampe/docker-build branch August 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeffryes mjeffryes mjeffryes approved these changes

@cnunciato cnunciato Awaiting requested review from cnunciato

Assignees

@blampe blampe

Labels
None yet
Projects
None yet
Milestone
0.108
Development

Successfully merging this pull request may close these issues.

update templates to use docker-build
2 participants
@blampe @mjeffryes