-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent java template from using 6.0 alpha versions #624
Conversation
Related to pulumi/pulumi-aws#2658 |
The latest version of aws is 5.4. I've validated that this works as expected.
|
Alpha versions are considered less than the numeric version so even with @cnunciato This should be looked at for all java programs to avoid pulling in alpha releases prior to the next major release. |
This look's good 🙏 It doesn't shield users from versions such as https://repo1.maven.org/maven2/com/pulumi/aws/5.43.0-alpha.1689671883+f787a47a/ but those are not currently known to be affected. |
True, I could set it to 5.43 explicitly, but didn't want to eliminate 5.5* from being used in case there was some other emergent release. My goal is to prevent the next major version's alpha releases from being consumed. |
@cnunciato I'm not sure why this test is failing. Could you help take a look please?
Also, note the scaleway update due to failing tests around go being 1.18 max expected but 1.20 in the actual program. |
@mnlumi It looks like the The checkpoint suggests the version that failed (producing the diff) was 5.4.0. |
aws-java/pom.xml
Outdated
@@ -26,7 +26,7 @@ | |||
<dependency> | |||
<groupId>com.pulumi</groupId> | |||
<artifactId>aws</artifactId> | |||
<version>(,6.0.0]</version> | |||
<version>(,5.9]</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use 5.99
. Current AWS provider release is already at 5.42.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ringods for catching this!
No description provided.