Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent java template from using 6.0 alpha versions #624

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

mnlumi
Copy link
Contributor

@mnlumi mnlumi commented Aug 2, 2023

No description provided.

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

Related to pulumi/pulumi-aws#2658

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

The latest version of aws is 5.4. I've validated that this works as expected.

Do you want to perform this update? details
+ pulumi:pulumi:Stack: (create)
    [urn=urn:pulumi:dev::aws-java-2::pulumi:pulumi:Stack::aws-java-2-dev]
    + aws:s3/bucket:Bucket: (create)
        [urn=urn:pulumi:dev::aws-java-2::aws:s3/bucket:Bucket::my-bucket]
        [provider=urn:pulumi:dev::aws-java-2::pulumi:providers:aws::default_5_4_0::......]
        acl         : "private"
        bucket      : "my-bucket-f3a10fd"
        forceDestroy: false
    --outputs:--
    bucketName: "my-bucket-f3a10fd"

@mnlumi mnlumi requested a review from cnunciato August 2, 2023 20:43
@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

Alpha versions are considered less than the numeric version so even with <version>[5.0.0,6.0.0]</version>, the 6.0.0-alpha will be selected.

@cnunciato This should be looked at for all java programs to avoid pulling in alpha releases prior to the next major release.

@t0yv0
Copy link
Member

t0yv0 commented Aug 2, 2023

This look's good 🙏

It doesn't shield users from versions such as https://repo1.maven.org/maven2/com/pulumi/aws/5.43.0-alpha.1689671883+f787a47a/ but those are not currently known to be affected.

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

This look's good 🙏

It doesn't shield users from versions such as https://repo1.maven.org/maven2/com/pulumi/aws/5.43.0-alpha.1689671883+f787a47a/ but those are not currently known to be affected.

True, I could set it to 5.43 explicitly, but didn't want to eliminate 5.5* from being used in case there was some other emergent release. My goal is to prevent the next major version's alpha releases from being consumed.

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 2, 2023

@cnunciato I'm not sure why this test is failing. Could you help take a look please?

  error: error: no changes were expected but changes were proposed

Also, note the scaleway update due to failing tests around go being 1.18 max expected but 1.20 in the actual program.

@cnunciato
Copy link
Contributor

cnunciato commented Aug 3, 2023

@mnlumi It looks like the aws-java test passed for your first commit, but started failing with the second. From the output, it looks like follow-up updates to the templated program produce a diff, which they shouldn't:

image

The checkpoint suggests the version that failed (producing the diff) was 5.4.0.

aws-java/pom.xml Outdated
@@ -26,7 +26,7 @@
<dependency>
<groupId>com.pulumi</groupId>
<artifactId>aws</artifactId>
<version>(,6.0.0]</version>
<version>(,5.9]</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use 5.99. Current AWS provider release is already at 5.42.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ringods for catching this!

@cnunciato cnunciato merged commit 68a1c1b into master Aug 3, 2023
5 checks passed
@cnunciato cnunciato deleted the mnlumi/java-aws-lock branch August 3, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants