generated from pulumi/pulumi-provider-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pulumi-go-provider as a provider framework #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to maintain our own gen code, we can use the pulumi binary for that. This makes it important that we use the right version of the pulumi binary, so we use the Makefile to ensure the version of pulumi used matches the version of pulumi we depend on in `provider/go.mod`. We use a similar pattern in other native providers.
I'm seeing test failures from canceled jobs leaking stacks. An immediate fix is to allow stack names to float.
Closing in favor of #258. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
This PR switches the entire provider to use https://github.com/pulumi/pulumi-go-provider, improving the authoring and correctness experience and increasing the development velocity for adding new resources.
This RP relies on pulumi/pulumi-go-provider#210 (not yet merged) and will not be fully backwards compatible with the current version until pulumi/pulumi-go-provider#193 is implemented.